Add More EQ Bands

Share Feedback
85

Great work @bvijay and @Theremino !!!

2 Likes
86

Thanks @james!

Kudos to @Theremino for the hard work they have put in to implement the feature enhancements!

1 Like
87

I just want to tell you guys, I’ve been testing this and finally—it’s amazing. This is bananas! Wonderful job, you guys rock! Seriously, @bvijay @Theremino :love_you_gesture: :heart:

1 Like
88

Dear bvijay,
in the past days the automatic update of FxSound has detected that my version was to be updated. But after the automatic update the file FxSound.exe was not present in the folder C:\Program Files\FxSound LLC\FxSound

So I have uninstalled all using the Windows control panel and then I have tried to install your new code downloading it from this page: Download FxSound - Boost Your Sound On Windows
but the code installed is the old 9 bands code.

Then I have downloaded the code from here GitHub - fxsound2/fxsound-app at dev
But unfortunately it not compile and I get the following errors:
Cannot open include file: ‘juce_core/juce_core_CompilationTime.cpp’: No such file or directory
Cannot open include file: ‘juce_graphics/juce_graphics_Harfbuzz.cpp’: No such file or directory

Can you please send to me the link to the right version to download, so I can test it ?
Or even better a link to the compiled FxSound.exe ?

89

Hi @Theremino ,

The release version 1.1.34.0 does not have the equalizer changes that I have integrated from your code. You can install the beta version 1.2.0.0 from https://github.com/fxsound2/fxsound-app/releases/download/beta/fxsound_setup.exe for the equalizer, filter Q, master gain changes etc.

For supporting ARM64 CPU, we had to upgrade to latest JUCE framework. So please download JUCE 8.0.8 to compile the code in fxsound2/fxsound-app at dev

Sorry that I haven’t updated the build instructions in readme.

Also, I have integrated only the audio features from your code at this stage. We can take the UI changes in subsequent releases.

It would be a great help if you could review the code changes in fxsound2/fxsound-app at dev branch and see if all your audio feature implementation is in place.

1 Like
90

Thanks,
now with your suggestions I’ve managed to recompile it.

I tested it and found that the basic functionality is fine.

  • It loaded my presets I made with 31 bands.
  • It also correctly restored the balance I had set to -2dB.
  • You’ve always kept the decibel gain values ​​active, so they work on tablets too.
  • You’ve correctly retained the variable band centers for 5 and 10 bands.
  • I also checked all the English and Italian translations and found no errors.

So you’ve really done a great job and are incredibly precise. I was expecting to find a lot of errors, but nothing.

In terms of ease of use, however, I really miss the white borders on the windows and the ability to adjust the main window while the settings window is open. And of course, all the other little refinements I’ve made to the graphics. The removal of that red, bold DONATE, which I think is a bit excessive on the main page, the lack of a direct link to the forum, the windows that juxtapose and connect, the slightly grayed-out boxes to highlight them, etc.

There are so many small fixes that if you wanted to implement them all, you’d have to work for a very long time.

So, wouldn’t it have been easier to start from my complete version and add your latest changes, which weren’t many and could have been done quickly since you’re certainly familiar with them?

2 Likes
91

If they just take your whole work, it’s like copying and only changing a little. They need to be careful, since there’s still a lot more that has to be added later.

92

Copying wouldn’t be a problem! We made it as a gift and would be happy if it saved you work.

2 Likes
93

Thanks @Theremino for validating and reviewing the merge of audio features. Its great to hear that the audio features are merged correctly.

I understand that you are disappointed in not seeing all the UI changes you have done after all the hard work you have put in for making those changes.

Here are the reasons for holding the merge of these changes at the moment and taking them in a staged manner when required.

  • There have been requests from users to allow multiple colour theme options. So, we will review how your graphics changes will fit into custom colour theme and take it up.
  • We are limited in terms of resources to support. So, instead of adding to many features in the same release and then addressing support requests on the new features, we wanted to prioritize the audio features first.
  • We have a long pending request to fix all the accessibility issues to make the application user friendly for the visually challenged. So, I had to hold on adding too many new UI options.
  • We are planning to replace the Donate text button with a simple icon button for donate.

We truly appreciate the effort and thought you’ve put into to your implementation, and I we hope you will understand our point of view and plan to bring in your UI features gradually.

2 Likes
94

No problem, my suggestions were just to save you some work, but if you prefer a different approach, that’s fine.
In this case, however, we’ll keep our separate version, which I find more convenient to use.

95

Sure, that would be fine.

If you are planning to maintain the code in a GitHub repo, please let us know. It would help us to keep track of the development and sync the changes.

My suggestion is to fork your repo from fxsound2/fxsound-app: FxSound application and DSP source code, checkout from tag v1.1.31.0 which was your baseline and then add your 2.0.x code.

96

If you do it, I might try using it. I’m telling you this because I tried to get started once, but then I immediately deleted everything to avoid making a mess.
You should also explain to me how to create a single file to give users for installation. I tried that too, but I didn’t understand anything. There’s an “installer” folder in the project, but maybe it refers to something else…
So I think it’s easier for me to keep our project and our installer as it is now, so I can understand it.
If you think it’s possible to prepare it yourself and then explain how to use it, you can download our latest version, which is on the website here:
https://www.theremino.com/wp-content/uploads/files/fxsound-app-main_V2.0.4.zip

97

I apologize for my inability to follow GitHub’s rules, but you have to consider that we have about 150 applications to maintain, some of which are really heavy.
So we’ve developed our own working methods, and it’s not easy for me to change them. Also because I’m a super-old guy, and the few neurons I have are already all busy with the thousand new things I’m developing.

98

Hi. I just wanted to express my thanks for all you hard work. This app really

saved my computer setup i had such weak bass response before. I tried others, but i

like this one so much better after the changes. Beta version working great so far.

Thanks again.

Mark

1 Like
99

Hi @Theremino , For building the installer, you need Advanced Installer. We also sign the installer build and other binaries with digital certificate from DigiCert. But I am not sure that if there are any legal implications if you use FxSound branding but sign your binaries with your own digital certificate.

I can help with setting up your code in a GitHub repo. Do you have a GitHub account?

100

No, thanks, it’s too complicated, and I don’t see any advantage in making things so complicated and then not even being able to install it.
It’s better to stick with what we’ve always done, with everything open source on our site.
We’ll switch to your version and remove everything from our site (except a link to send you visits) only if you also implement the graphics the way we like them.

101

Actually, I don’t really like your installer file. That’s why I need it directly from the FxSound team — it’s more convenient. When I try your installer, it requires another installer, which isn’t as transparent as the original one from the FxSound team itself.

102

You’re right, ours isn’t a real installer because we at T-System are a completely non-profit organization and can’t afford to pay for a real installer with the required signatures, nor would we have the time to learn how to do it.

And that’s why I hoped our work could be integrated into the official release of FxSound, including all the improvements we’ve made to the windows. I’m referring primarily to the ability to simultaneously use the main window controls even while the Options window is open. But also to the improved visibility of the controls and window borders, as well as dozens of other little conveniences we’ve developed over 400 hours.

However, you don’t need to use our installer; just take the FxSound.exe file we compiled and place it in the folder: C:\Program Files\FxSound LLC\FxSound

1 Like
103

Hey guys, just made an account to thank you for this absolutely amazing software. I too, have been really missing some more EQ control. I have downloaded version 1.2 and I see the 31 bands. I will be testing with my monitors soon! Thank you so so much for your incredibly hard work. I’m a software dev myself, and I understand how hard these contributions are. You’re welcome to checkout my site at talkartech.com for any inquiries.

Alexander T. Karslake

2 Likes
104

Dear bvijay, maybe there is a small problem in your installer, I’ll explain what happened to me:

- In the last few days I have always used my version which I get simply by replacing FxSound.exe in the C:\Program Files\FxSound LLC\FxSound folder (without even using my installer)

- This morning I received a message that there is a new version of FxSound and I ran your installer all the way to the end to try it.

- At the end of the installer execution, and without the installer indicating any errors, the FxSound.exe file was missing from the C:\Program Files\FxSound LLC\FxSound folder.

In the following image you can see how the folder created by the installer is composed.

FxSound_Folder
FxSound_Folder799×787 51 KB